git: ab6145c97683 - main - style: tweak tab after #define advice

Warner Losh imp at FreeBSD.org
Fri Jun 11 16:54:27 UTC 2021


The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=ab6145c976833e4363f430143a16451b57cbf621

commit ab6145c976833e4363f430143a16451b57cbf621
Author:     Warner Losh <imp at FreeBSD.org>
AuthorDate: 2021-06-11 16:33:04 +0000
Commit:     Warner Losh <imp at FreeBSD.org>
CommitDate: 2021-06-11 16:54:06 +0000

    style: tweak tab after #define advice
    
    Once upon a time, #define<tab> was cultural thing. However, even when it
    was promulgated, it was a minority usage. 20 years ago the split was
    30k/69k (tab/space) and today the split is 80k/546k (tab/space). Update
    guidance to allow either with the usual suggestion to be consistent
    within a file.
    
    Reviewed by:            sef, allenjude, 0mp (prior rev), jhb
    Sponsored by:           Netflix
    Differential Revision:  https://reviews.freebsd.org/D30254
---
 share/man/man9/style.9 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/share/man/man9/style.9 b/share/man/man9/style.9
index 10ca64cde817..9744b1c11a45 100644
--- a/share/man/man9/style.9
+++ b/share/man/man9/style.9
@@ -215,9 +215,9 @@ macros (ones that have side effects), and the names of macros for
 manifest constants, are all in uppercase.
 The expansions of expression-like macros are either a single token
 or have outer parentheses.
-Put a single tab character between the
+Put a single space or tab character between the
 .Ic #define
-and the macro name.
+and the macro name, but be consistent within a file.
 If a macro is an inline expansion of a function, the function name is
 all in lowercase and the macro has the same name all in uppercase.
 .\" XXX the above conflicts with ANSI style where the names are the


More information about the dev-commits-src-all mailing list