git: 92f49c769b4e - stable/13 - smartpqi: clear CCBs allocated on the stack

Warner Losh imp at FreeBSD.org
Thu Jun 3 13:53:31 UTC 2021


The branch stable/13 has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=92f49c769b4ef51163151c3991357a08941e232d

commit 92f49c769b4ef51163151c3991357a08941e232d
Author:     Edward Tomasz Napierala <trasz at FreeBSD.org>
AuthorDate: 2021-05-28 06:33:37 +0000
Commit:     Warner Losh <imp at FreeBSD.org>
CommitDate: 2021-06-03 13:53:12 +0000

    smartpqi: clear CCBs allocated on the stack
    
    Differential Revision:          https://reviews.freebsd.org/D30299
    
    (cherry picked from commit e20e60be501204c3ba742e266afecc6c6e498a6c)
---
 sys/dev/smartpqi/smartpqi_cam.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sys/dev/smartpqi/smartpqi_cam.c b/sys/dev/smartpqi/smartpqi_cam.c
index 3d39e1ffbdd4..e389eb143e4a 100644
--- a/sys/dev/smartpqi/smartpqi_cam.c
+++ b/sys/dev/smartpqi/smartpqi_cam.c
@@ -1140,6 +1140,7 @@ smartpqi_adjust_queue_depth(struct cam_path *path, uint32_t queue_depth)
 
 	DBG_INFO("IN\n");
 
+	memset(&crs, 0, sizeof(crs));
 	xpt_setup_ccb(&crs.ccb_h, path, 5);
 	crs.ccb_h.func_code = XPT_REL_SIMQ;
 	crs.ccb_h.flags = CAM_DEV_QFREEZE;
@@ -1262,6 +1263,7 @@ register_sim(struct pqisrc_softstate *softs, int card_index)
 	 * derived from the FW.
  	 */
 	softs->os_specific.path = ccb->ccb_h.path;
+	memset(&csa, 0, sizeof(csa));
 	xpt_setup_ccb(&csa.ccb_h, softs->os_specific.path, 5);
 	csa.ccb_h.func_code = XPT_SASYNC_CB;
 	csa.event_enable = AC_FOUND_DEVICE;
@@ -1294,6 +1296,7 @@ deregister_sim(struct pqisrc_softstate *softs)
 	}
 
 
+	memset(&csa, 0, sizeof(csa));
 	xpt_setup_ccb(&csa.ccb_h, softs->os_specific.path, 5);
 	csa.ccb_h.func_code = XPT_SASYNC_CB;
 	csa.event_enable = 0;


More information about the dev-commits-src-all mailing list