git: 9fd0cda92d33 - main - e1000: Add missing branch prediction

Kevin Bowling kbowling at FreeBSD.org
Tue Jul 20 07:23:24 UTC 2021


The branch main has been updated by kbowling (ports committer):

URL: https://cgit.FreeBSD.org/src/commit/?id=9fd0cda92d3346e1daa30eb48e185e2077ac0566

commit 9fd0cda92d3346e1daa30eb48e185e2077ac0566
Author:     Kevin Bowling <kbowling at FreeBSD.org>
AuthorDate: 2021-07-20 07:21:21 +0000
Commit:     Kevin Bowling <kbowling at FreeBSD.org>
CommitDate: 2021-07-20 07:21:21 +0000

    e1000: Add missing branch prediction
    
    I missed this edit from the ixgbe review (D30074)
    
    Reviewed by:    gallatin
    MFC after:      2 weeks
    Differential Revision:  https://reviews.freebsd.org/D30073
---
 sys/dev/e1000/igb_txrx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/e1000/igb_txrx.c b/sys/dev/e1000/igb_txrx.c
index ac768f84f810..75c5c160bf3e 100644
--- a/sys/dev/e1000/igb_txrx.c
+++ b/sys/dev/e1000/igb_txrx.c
@@ -527,7 +527,7 @@ igb_rx_checksum(uint32_t staterr, if_rxd_info_t ri, uint32_t ptype)
 		return;
 
 	/* If there is a layer 3 or 4 error we are done */
-	if (errors & (E1000_RXD_ERR_IPE | E1000_RXD_ERR_TCPE))
+	if (__predict_false(errors & (E1000_RXD_ERR_IPE | E1000_RXD_ERR_TCPE)))
 		return;
 
 	/* IP Checksum Good */


More information about the dev-commits-src-all mailing list