git: 297e9f364b5a - main - loader: Don't reserve space for symbols twice.

Warner Losh imp at FreeBSD.org
Mon Jul 12 21:30:38 UTC 2021


The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=297e9f364b5aa243572ee52b1faef9b3542c1c9e

commit 297e9f364b5aa243572ee52b1faef9b3542c1c9e
Author:     Warner Losh <imp at FreeBSD.org>
AuthorDate: 2021-07-12 21:17:05 +0000
Commit:     Warner Losh <imp at FreeBSD.org>
CommitDate: 2021-07-12 21:30:27 +0000

    loader: Don't reserve space for symbols twice.
    
    The current code bumps lastaddr twice for the symbol table
    location. However, the first bump is bogus and results in wasted
    space. Remove it.
    
    PR:                     110995
    Sponsored by:           Netflix
    Differential Revision:  https://reviews.freebsd.org/D31017
---
 stand/common/load_elf_obj.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/stand/common/load_elf_obj.c b/stand/common/load_elf_obj.c
index 78ece02433c6..f3c84cf31368 100644
--- a/stand/common/load_elf_obj.c
+++ b/stand/common/load_elf_obj.c
@@ -282,8 +282,6 @@ __elfN(obj_loadimage)(struct preloaded_file *fp, elf_file_t ef, uint64_t off)
 		case SHT_SYMTAB:
 			nsym++;
 			ef->symtabindex = i;
-			shdr[i].sh_addr = (Elf_Addr)lastaddr;
-			lastaddr += shdr[i].sh_size;
 			break;
 		}
 	}


More information about the dev-commits-src-all mailing list