git: 4debb6a3a027 - stable/13 - libpfctl: memory leak fix

Kristof Provost kp at FreeBSD.org
Fri Jul 9 13:24:31 UTC 2021


The branch stable/13 has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=4debb6a3a027498aa657fcb79007d9936fc8b771

commit 4debb6a3a027498aa657fcb79007d9936fc8b771
Author:     Kristof Provost <kp at FreeBSD.org>
AuthorDate: 2021-06-30 11:02:35 +0000
Commit:     Kristof Provost <kp at FreeBSD.org>
CommitDate: 2021-07-09 08:08:37 +0000

    libpfctl: memory leak fix
    
    We must remember to free the nvlist we create from the kernel's response
    to DIOCGETSTATESNV, on every iteration.
    
    Reviewed by:    donner
    MFC after:      1 week
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    Differential Revision:  https://reviews.freebsd.org/D30957
    
    (cherry picked from commit 0e9f1892ec739d7fbd854af699507167a0a5dde2)
---
 lib/libpfctl/libpfctl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/libpfctl/libpfctl.c b/lib/libpfctl/libpfctl.c
index 524e2472238e..bbb53edf8bc1 100644
--- a/lib/libpfctl/libpfctl.c
+++ b/lib/libpfctl/libpfctl.c
@@ -727,6 +727,7 @@ pfctl_get_states(int dev, struct pfctl_states *states)
 			goto out;
 		}
 
+		nvlist_destroy(nvl);
 		nvl = nvlist_unpack(nv.data, nv.len, 0);
 		if (nvl == NULL) {
 			error = EIO;


More information about the dev-commits-src-all mailing list