git: 29e2dbd42c3e - main - ocs_fc: Add gendump and dump_to_host ioctl command support.

Kristof Provost kp at FreeBSD.org
Tue Jul 6 19:18:32 UTC 2021


On 6 Jul 2021, at 21:04, Alexander Motin wrote:
> On 06.07.2021 14:55, Kristof Provost wrote:
>> On 6 Jul 2021, at 17:48, Ram Kishore Vegesna wrote:
>>     The branch main has been updated by ram:
>>
>>     URL:
>>     https://cgit.FreeBSD.org/src/commit/?id=29e2dbd42c3e2e10e606b3414f4d0c53021d4e86
>>
>>     commit 29e2dbd42c3e2e10e606b3414f4d0c53021d4e86
>>     Author: Ram Kishore Vegesna <ram at FreeBSD.org>
>>     AuthorDate: 2021-06-24 07:05:00 +0000
>>     Commit: Ram Kishore Vegesna <ram at FreeBSD.org>
>>     CommitDate: 2021-07-06 15:38:11 +0000
>>
>>     ocs_fc: Add gendump and dump_to_host ioctl command support.
>>
>>     Support to generate firmware dump.
>>
>>     Approved by: mav(mentor)
>>     ---
>>     sys/dev/ocs_fc/ocs_gendump.c | 388
>>     +++++++++++++++++++++++++++++++++++++++++++
>>     sys/dev/ocs_fc/ocs_gendump.h | 42 +++++
>>     sys/dev/ocs_fc/ocs_ioctl.c | 13 +-
>>     sys/dev/ocs_fc/ocs_ioctl.h | 3 +
>>     sys/dev/ocs_fc/ocs_mgmt.c | 152 ++---------------
>>     sys/dev/ocs_fc/ocs_os.c | 3 +-
>>     sys/dev/ocs_fc/ocs_os.h | 3 +-
>>     sys/modules/ocs_fc/Makefile | 3 +-
>>     8 files changed, 449 insertions(+), 158 deletions(-)
>>
>> I’m seeing this build failure (amd64, GENERIC kernel):
>>
>> |ld: error: undefined symbol: ocs_gen_dump >>> referenced by
>> ocs_mgmt.c:485 (/usr/src/sys/dev/ocs_fc/ocs_mgmt.c:485) >>>
>> ocs_mgmt.o:(ocs_mgmt_exec) ld: error: undefined symbol: 
>> ocs_dump_to_host
>>>>> referenced by ocs_mgmt.c:489
>> (/usr/src/sys/dev/ocs_fc/ocs_mgmt.c:489) >>> 
>> ocs_mgmt.o:(ocs_mgmt_exec)
>> *** [kernel.full] Error code 1 |
>>
>> Does that ring any bells?
>
> d0732fa81963 should fix it.  Sorry for breakage.
>
That works. Thanks for the quick fix.

— Kristof


More information about the dev-commits-src-all mailing list