git: dfcf1bd2e10e - stable/13 - pf: make sure the dtrace probe has safe access to state

Mateusz Guzik mjg at FreeBSD.org
Mon Jul 5 11:33:54 UTC 2021


The branch stable/13 has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=dfcf1bd2e10e6d2fe32977862bc13f4ff74e3d76

commit dfcf1bd2e10e6d2fe32977862bc13f4ff74e3d76
Author:     Mateusz Guzik <mjg at FreeBSD.org>
AuthorDate: 2021-06-28 19:32:20 +0000
Commit:     Mateusz Guzik <mjg at FreeBSD.org>
CommitDate: 2021-07-05 11:32:13 +0000

    pf: make sure the dtrace probe has safe access to state
    
    Reviewed by:    kp
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    
    (cherry picked from commit d26ef5c7ac830812f07a02787f25fed5d6f8609e)
---
 sys/netpfil/pf/pf.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c
index 92e93b62e85f..3846e5335a2a 100644
--- a/sys/netpfil/pf/pf.c
+++ b/sys/netpfil/pf/pf.c
@@ -6318,11 +6318,12 @@ done:
 		}
 		break;
 	}
-	if (s)
-		PF_STATE_UNLOCK(s);
 
 	SDT_PROBE4(pf, ip, test, done, action, reason, r, s);
 
+	if (s)
+		PF_STATE_UNLOCK(s);
+
 	return (action);
 }
 #endif /* INET */


More information about the dev-commits-src-all mailing list