git: 6e26189be406 - main - Fix loader detection of vbefb support on !amd64

Toomas Soome tsoome at me.com
Thu Jan 28 07:51:37 UTC 2021



> On 28. Jan 2021, at 09:50, Dimitry Andric <dim at FreeBSD.org> wrote:
> 
> On 28 Jan 2021, at 00:08, John Baldwin <jhb at FreeBSD.org> wrote:
>> 
>> On 1/27/21 1:29 PM, Dimitry Andric wrote:
>>> The branch main has been updated by dim:
>>> URL: https://cgit.FreeBSD.org/src/commit/?id=6e26189be406a9a3799074b16925e6cd63cc703b
>>> commit 6e26189be406a9a3799074b16925e6cd63cc703b
>>> Author:     Dimitry Andric <dim at FreeBSD.org>
>>> AuthorDate: 2021-01-27 21:28:43 +0000
>>> Commit:     Dimitry Andric <dim at FreeBSD.org>
>>> CommitDate: 2021-01-27 21:28:43 +0000
>>>    Fix loader detection of vbefb support on !amd64
>>>         On i386, after 6c7a932d0b8baaaee16eca0ba061bfa6e0e57bfd, the vbefb vt
>>>    driver was no longer detected by the loader, if any kernel module was
>>>    loaded after the kernel itself.
>>>         This was caused by the parse_vt_drv_set() function being called multiple
>>>    times, resetting the detection flag. (It was called multiple times,
>>>    becuase i386 .ko files are shared objects like the kernel proper, while
>>>    this is not the case on amd64.)
>>>         Fix this by skipping the set_vt_drv_set lookup if vbefb was already
>>>    detected.
>>>         Reviewed by:    tsoome
>> 
>> Does the state get reset if you unload one kernel and then load a different
>> one (e.g. via interactive 'unload' and 'load /path/to/my/kernel')?
> 
> Ha, good one! I don't think it is.
> 
> -Dimitry
> 

I’m about to push it:)

yes, it was missed.

thanks,
toomas


More information about the dev-commits-src-all mailing list