git: 5fe433a6e4d8 - main - netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support

[Lutz Donnerhacke]

On Sun, Jan 24, 2021 at 07:41:12PM +0000, Lutz Donnerhacke wrote:
> commit 5fe433a6e4d8cab6b64284698301afc0c55a9db2
> Author:     Neel Chauhan <nc at FreeBSD.org>
> AuthorDate: 2021-01-24 19:23:39 +0000
> Commit:     Lutz Donnerhacke <donner at FreeBSD.org>
> CommitDate: 2021-01-24 19:38:35 +0000
> 
>     netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support
>     
>     This extends upon the RFC 6598 support to libalias/ipfw in r357092.
>     
>     Reviewed By:    manpages (bcr), donner, adrian, kp
>     Approved by:    kp (mentor)
>     MFC after:      1 month
>     Differential Revision: https://reviews.freebsd.org/D23461

git allows us to distinguish between Author and Committer.

I used this (after a discussion with my mentor) to attribute a foreign
submission (nc has no src bit) directly to the Autor instead of setting
"Submitted by:" (as used under subversion)

Question: What is the prefered method to commit for an other person?

traditional:
> Author: committer
> Commit: committer
>
> patch
> Submitted by: author

or (as above):
> Author: author
> Commit: committer
>
> patch

Any opinions?