git: e83b514a9563 - main - cat: depend on Makefile to rebuild when WITH_CASPER changes

Enji Cooper yaneurabeya at gmail.com
Wed Jan 20 08:31:56 UTC 2021


> On Jan 17, 2021, at 9:22 AM, Ed Maste <emaste at freebsd.org> wrote:
> 
> The branch main has been updated by emaste:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=e83b514a9563d5812c9d158ff976f0de96bd90e0
> 
> commit e83b514a9563d5812c9d158ff976f0de96bd90e0
> Author:     Ed Maste <emaste at FreeBSD.org>
> AuthorDate: 2021-01-17 17:15:40 +0000
> Commit:     Ed Maste <emaste at FreeBSD.org>
> CommitDate: 2021-01-17 17:19:00 +0000
> 
>    cat: depend on Makefile to rebuild when WITH_CASPER changes
> 
>    We try to ensure building WITHOUT_CLEAN (or -DNO_CLEAN) works on an
>    ongoing basis.  b7ab6832cd98 changed cat to build w/o -DWITH_CASPER
>    by default; add a cat.o dependency on the Makefile so that it gets
>    rebuilt.
> ---
> bin/cat/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/bin/cat/Makefile b/bin/cat/Makefile
> index cce69d8aad9e..06bb071363f8 100644
> --- a/bin/cat/Makefile
> +++ b/bin/cat/Makefile
> @@ -22,5 +22,7 @@ SUBDIR.${MK_TESTS}+= tests
> #LIBADD+=        cap_net
> #CFLAGS+=-DWITH_CASPER
> #.endif
> +# Depend on Makefile to rebiuld when WITH_CASPER changes
> +cat.o:	Makefile


Hi Ed,

Could this maybe use ${MAKEFILE} or .MAKE.MAKEFILES, e.g.,  ${.MAKE.MAKEFILES:[0]}, instead?

IIRC meta mode might take care of this automatically, but bdrewery could answer this definitively.

Cheers!
-Enji


More information about the dev-commits-src-all mailing list