git: b7ab6832cd98 - main - cat: disable building it with Casper

[Mariusz Zaborski]

Hello,

Seems like your cat.o wasn't rebuild.
Did you use NO_CLEAN flag?
It seems to work on:
https://github.com/freebsd/freebsd-src/runs/1715237892 and on my
machine.

Can you try doing:
make buildenv
cd bin/cat
make clean
make

Thanks,
Mariusz

On Sun, 17 Jan 2021 at 01:58, Cy Schubert <Cy.Schubert at cschubert.com> wrote:
>
> In message <202101170021.10H0LZEk066670 at gitrepo.freebsd.org>, Mariusz
> Zaborski
> writes:
> > The branch main has been updated by oshogbo:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=b7ab6832cd988aff7f4e468e507c314d
> > d7641638
> >
> > commit b7ab6832cd988aff7f4e468e507c314dd7641638
> > Author:     Mariusz Zaborski <oshogbo at FreeBSD.org>
> > AuthorDate: 2021-01-17 00:04:28 +0000
> > Commit:     Mariusz Zaborski <oshogbo at FreeBSD.org>
> > CommitDate: 2021-01-17 00:21:46 +0000
> >
> >     cat: disable building it with Casper
> >
> >     We want to measure what are the actual cost of sandboxing cat(1).
> >
> >     Requested by:   mjg, cy, Mike Karels
> >     Discussed with: rwatson, markj
> > ---
> >  bin/cat/Makefile | 13 +++++++------
> >  1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/bin/cat/Makefile b/bin/cat/Makefile
> > index abfdcbcfbb2e..cce69d8aad9e 100644
> > --- a/bin/cat/Makefile
> > +++ b/bin/cat/Makefile
> > @@ -15,11 +15,12 @@ CFLAGS+=-DBOOTSTRAP_CAT
> >  HAS_TESTS=
> >  SUBDIR.${MK_TESTS}+= tests
> >
> > -.if ${MK_CASPER} != "no" && !defined(RESCUE) && !defined(BOOTSTRAPPING)
> > -LIBADD+=        casper
> > -LIBADD+=        cap_fileargs
> > -LIBADD+=        cap_net
> > -CFLAGS+=-DWITH_CASPER
> > -.endif
> > +# Temporary disable building cat with Casper.
> > +#.if ${MK_CASPER} != "no" && !defined(RESCUE) && !defined(BOOTSTRAPPING)
> > +#LIBADD+=        casper
> > +#LIBADD+=        cap_fileargs
> > +#LIBADD+=        cap_net
> > +#CFLAGS+=-DWITH_CASPER
> > +#.endif
> >
> >  .include <bsd.prog.mk>
> >
>
> Hi,
>
> Almost there.
>
> ld: error: undefined symbol: cap_init
> >>> referenced by cat.c:154 (/opt/src/git-src/bin/cat/cat.c:154)
> >>>               cat.o:(main)
>
> ld: error: undefined symbol: fileargs_cinit
> >>> referenced by cat.c:158 (/opt/src/git-src/bin/cat/cat.c:158)
> >>>               cat.o:(main)
>
> ld: error: undefined symbol: cap_service_open
> >>> referenced by cat.c:131 (/opt/src/git-src/bin/cat/cat.c:131)
> >>>               cat.o:(main)
>
> ld: error: undefined symbol: cap_net_limit_init
> >>> referenced by cat.c:135 (/opt/src/git-src/bin/cat/cat.c:135)
> >>>               cat.o:(main)
>
> ld: error: undefined symbol: cap_net_limit_name2addr_family
> >>> referenced by cat.c:141 (/opt/src/git-src/bin/cat/cat.c:141)
> >>>               cat.o:(main)
> --- all_subdir_kerberos5 ---
> --- libheimntlm.so.11.debug ---
> objcopy --only-keep-debug libheimntlm.so.11.full libheimntlm.so.11.debug
> --- libheimntlm.so.11 ---
> objcopy --strip-debug --add-gnu-debuglink=libheimntlm.so.11.debug
> libheimntlm.so.11.full libheimntlm.so.11
> --- all_subdir_lib ---
> --- init_test ---
> (cd /opt/src/git-src/lib/csu/tests/dynamic &&  DEPENDFILE=.depend.init_test
>  NO_SUBDIR=1 make -f /opt/src/git-src/lib/csu/tests/dynamic/Makefile
> _RECURSING_PROGS=t  PROG=init_test )
> --- all_subdir_bin ---
> ld: error: undefined symbol: cap_net_limit
> >>> referenced by cat.c:143 (/opt/src/git-src/bin/cat/cat.c:143)
> >>>               cat.o:(main)
>
> ld: error: undefined symbol: cap_close
> >>> referenced by cat.c:168 (/opt/src/git-src/bin/cat/cat.c:168)
> >>>               cat.o:(main)
>
> ld: error: undefined symbol: fileargs_open
> >>> referenced by cat.c:263 (/opt/src/git-src/bin/cat/cat.c:263)
> >>>               cat.o:(scanfiles)
>
> ld: error: undefined symbol: fileargs_realpath
> >>> referenced by cat.c:441 (/opt/src/git-src/bin/cat/cat.c:441)
> >>>               cat.o:(scanfiles)
>
> ld: error: undefined symbol: cap_getaddrinfo
> >>> referenced by cat.c:444 (/opt/src/git-src/bin/cat/cat.c:444)
> >>>               cat.o:(scanfiles)
>
> ld: error: undefined symbol: cap_connect
> >>> referenced by cat.c:468 (/opt/src/git-src/bin/cat/cat.c:468)
> >>>               cat.o:(scanfiles)
> cc: error: linker command failed with exit code 1 (use -v to see invocation)
> *** [cat.full] Error code 1
>
> make[4]: stopped in /opt/src/git-src/bin/cat
>
> make[1]: stopped in /opt/src/git-src
>
> make: stopped in /opt/src/git-src
> exiting RC=2: building amd64
>
>
> --
> Cheers,
> Cy Schubert <Cy.Schubert at cschubert.com>
> FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  https://FreeBSD.org
> NTP:           <cy at nwtime.org>    Web:  https://nwtime.org
>
>         The need of the many outweighs the greed of the few.
>
>