git: f2a7b434b30e - main - Variable declarations are since C99 and r363250 allowed inside for-loops. Partial revert of bafb68265672.

Hans Petter Selasky hselasky at FreeBSD.org
Wed Jan 13 11:31:25 UTC 2021


The branch main has been updated by hselasky:

URL: https://cgit.FreeBSD.org/src/commit/?id=f2a7b434b30efe341d51c0c0b151614775771ab6

commit f2a7b434b30efe341d51c0c0b151614775771ab6
Author:     Hans Petter Selasky <hselasky at FreeBSD.org>
AuthorDate: 2021-01-13 11:27:04 +0000
Commit:     Hans Petter Selasky <hselasky at FreeBSD.org>
CommitDate: 2021-01-13 11:30:41 +0000

    Variable declarations are since C99 and r363250 allowed inside for-loops.
    Partial revert of bafb68265672.
    
    Suggested by:   mmel@
---
 sys/dev/gpio/gpioc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sys/dev/gpio/gpioc.c b/sys/dev/gpio/gpioc.c
index 83d55742a3a2..9e46b32ffcba 100644
--- a/sys/dev/gpio/gpioc.c
+++ b/sys/dev/gpio/gpioc.c
@@ -567,7 +567,6 @@ gpioc_probe(device_t dev)
 static int
 gpioc_attach(device_t dev)
 {
-	int i;
 	int err;
 	struct gpioc_softc *sc;
 	struct make_dev_args devargs;
@@ -583,7 +582,7 @@ gpioc_attach(device_t dev)
 		return (err);
 	sc->sc_pin_intr = malloc(sizeof(struct gpioc_pin_intr) * sc->sc_npins,
 	    M_GPIOC, M_WAITOK | M_ZERO);
-	for (i = 0; i < sc->sc_npins; i++) {
+	for (int i = 0; i < sc->sc_npins; i++) {
 		sc->sc_pin_intr[i].pin = malloc(sizeof(struct gpiobus_pin),
 		    M_GPIOC, M_WAITOK | M_ZERO);
 		sc->sc_pin_intr[i].sc = sc;
@@ -613,12 +612,11 @@ gpioc_detach(device_t dev)
 {
 	struct gpioc_softc *sc = device_get_softc(dev);
 	int err;
-	int i;
 
 	if (sc->sc_ctl_dev)
 		destroy_dev(sc->sc_ctl_dev);
 
-	for (i = 0; i < sc->sc_npins; i++) {
+	for (int i = 0; i < sc->sc_npins; i++) {
 		mtx_destroy(&sc->sc_pin_intr[i].mtx);
 		free(&sc->sc_pin_intr[i].pin, M_GPIOC);
 	}


More information about the dev-commits-src-all mailing list