git: 16079c7233be - main - hid: quiet -Wswitch

Ryan Libby rlibby at FreeBSD.org
Mon Jan 11 05:54:33 UTC 2021


The branch main has been updated by rlibby:

URL: https://cgit.FreeBSD.org/src/commit/?id=16079c7233be8bd6c88e3421a70c7ca87cfea370

commit 16079c7233be8bd6c88e3421a70c7ca87cfea370
Author:     Ryan Libby <rlibby at FreeBSD.org>
AuthorDate: 2021-01-11 05:53:15 +0000
Commit:     Ryan Libby <rlibby at FreeBSD.org>
CommitDate: 2021-01-11 05:53:15 +0000

    hid: quiet -Wswitch
    
    Gcc builds complained that not all switch cases are handled.  Add
    default cases to appease gcc.
    
    Reviewed by:    hselasky (previous version), wulf
    Sponsored by:   Dell EMC Isilon
    Differential Revision:  https://reviews.freebsd.org/D28082
---
 sys/dev/hid/hcons.c     |  3 +++
 sys/dev/hid/hgame.c     |  4 ++++
 sys/dev/hid/hpen.c      |  3 +++
 sys/dev/hid/ps4dshock.c | 13 +++++++++++++
 4 files changed, 23 insertions(+)

diff --git a/sys/dev/hid/hcons.c b/sys/dev/hid/hcons.c
index 559e84d468f3..33264116bc76 100644
--- a/sys/dev/hid/hcons.c
+++ b/sys/dev/hid/hcons.c
@@ -252,6 +252,9 @@ hcons_rel_volume_cb(HIDMAP_CB_ARGS)
 			evdev_push_key(evdev, code, 1);
 			evdev_push_key(evdev, code, 0);
 		}
+		break;
+	default:
+		break;
 	}
 
 	return (0);
diff --git a/sys/dev/hid/hgame.c b/sys/dev/hid/hgame.c
index 099af092a4e5..545c72e76d93 100644
--- a/sys/dev/hid/hgame.c
+++ b/sys/dev/hid/hgame.c
@@ -126,6 +126,10 @@ hgame_dpad_cb(HIDMAP_CB_ARGS)
 			sc->dpad_left = (data != 0);
 			break;
 		}
+		break;
+
+	default:
+		break;
 	}
 
 	return (0);
diff --git a/sys/dev/hid/hpen.c b/sys/dev/hid/hpen.c
index 430461d87727..1d505e14089f 100644
--- a/sys/dev/hid/hpen.c
+++ b/sys/dev/hid/hpen.c
@@ -126,6 +126,9 @@ hpen_battery_strenght_cb(HIDMAP_CB_ARGS)
 	case HIDMAP_CB_IS_RUNNING:
 		data = ctx.data;
 		/* TODO */
+		break;
+	default:
+		break;
 	}
 
 	return (0);
diff --git a/sys/dev/hid/ps4dshock.c b/sys/dev/hid/ps4dshock.c
index e0448947853e..eec26f808997 100644
--- a/sys/dev/hid/ps4dshock.c
+++ b/sys/dev/hid/ps4dshock.c
@@ -808,6 +808,10 @@ ps4dshock_hat_switch_cb(HIDMAP_CB_ARGS)
 		idx = MIN(nitems(hat_switch_map) - 1, (u_int)ctx.data);
 		evdev_push_abs(evdev, ABS_HAT0X, hat_switch_map[idx].x);
 		evdev_push_abs(evdev, ABS_HAT0Y, hat_switch_map[idx].y);
+		break;
+
+	default:
+		break;
 	}
 
 	return (0);
@@ -854,6 +858,9 @@ ps4dsacc_data_cb(HIDMAP_CB_ARGS)
 		    ((int64_t)ctx.data - calib->bias) * calib->sens_numer /
 		    calib->sens_denom);
 		break;
+
+	default:
+		break;
 	}
 
 	return (0);
@@ -879,6 +886,9 @@ ps4dsacc_tstamp_cb(HIDMAP_CB_ARGS)
 		sc->hw_tstamp = tstamp;
 		evdev_push_msc(evdev, MSC_TIMESTAMP, sc->ev_tstamp);
 		break;
+
+	default:
+		break;
 	}
 
 	return (0);
@@ -1020,6 +1030,9 @@ ps4dsmtp_final_cb(HIDMAP_CB_ARGS)
 			evdev_sync(evdev);
 		}
 		break;
+
+	default:
+		break;
 	}
 
 	/* Do execute callback at interrupt handler and detach */


More information about the dev-commits-src-all mailing list