git: facdd1cd2045 - main - cgem: add 64-bit support

Jessica Clarke jrtc27 at freebsd.org
Sun Jan 10 21:17:52 UTC 2021


On 10 Jan 2021, at 20:53, Mitchell Horne <mhorne at FreeBSD.org> wrote:
> diff --git a/sys/dev/cadence/if_cgem.c b/sys/dev/cadence/if_cgem.c
> index 3c5277452469..77337e977dcc 100644
> --- a/sys/dev/cadence/if_cgem.c
> +++ b/sys/dev/cadence/if_cgem.c
> @@ -77,6 +77,14 @@ __FBSDID("$FreeBSD$");
> #include <dev/mii/mii.h>
> #include <dev/mii/miivar.h>
> 
> +#ifdef EXT_RESOURCES
> +#include <dev/extres/clk/clk.h>
> +#endif
> +
> +#if INTPTR_MAX == INT64_MAX
> +#define CGEM64
> +#endif

This isn't going to work with CHERI. Perhaps a BUS_SPACE_MAXADDR check,
or SIZE_MAX? The former is probably preferable for PAE systems.

Jess



More information about the dev-commits-src-all mailing list