git: 82c7abe7785b - main - The "unsigned" type is the same like "unsigned int".

Andriy Gapon andriy.gapon at uabsd.com
Sat Jan 9 18:15:59 UTC 2021


On 2021-01-08 13:37, Hans Petter Selasky wrote:
> The branch main has been updated by hselasky:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=82c7abe7785bd8aeb290d91f80ddeb31e81407a5
> 
> commit 82c7abe7785bd8aeb290d91f80ddeb31e81407a5
> Author:     Hans Petter Selasky <hselasky at FreeBSD.org>
> AuthorDate: 2021-01-08 10:58:10 +0000
> Commit:     Hans Petter Selasky <hselasky at FreeBSD.org>
> CommitDate: 2021-01-08 11:35:54 +0000
> 
>     The "unsigned" type is the same like "unsigned int".
>     
>     MFC after: 1 week
>     Sponsored by: Mellanox Technologies // NVIDIA Networking
> ---
>  sys/dev/mlx5/mlx5_core/mlx5_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sys/dev/mlx5/mlx5_core/mlx5_main.c b/sys/dev/mlx5/mlx5_core/mlx5_main.c
> index d0b4027165ea..40cba09106f0 100644
> --- a/sys/dev/mlx5/mlx5_core/mlx5_main.c
> +++ b/sys/dev/mlx5/mlx5_core/mlx5_main.c
> @@ -708,7 +708,7 @@ static int wait_fw_init(struct mlx5_core_dev *dev, u32 max_wait_mili,
>  		if (warn_time_mili && time_after(jiffies, warn)) {
>  			mlx5_core_warn(dev,
>  			    "Waiting for FW initialization, timeout abort in %u s\n",
> -			    (unsigned int)(jiffies_to_msecs(end - warn) / 1000));
> +			    (unsigned)(jiffies_to_msecs(end - warn) / 1000));

I am not sure that we actually prefer "unsigned" over "unsigned int".
If you just wanted to make the line a bit shorter then u_int is what is
typically used in FreeBSD code.

>  			warn = jiffies + msecs_to_jiffies(warn_time_mili);
>  		}
>  		msleep(FW_INIT_WAIT_MS);
> 



More information about the dev-commits-src-all mailing list