git: 2d486ba15f33 - main - pkgbase: Move bectl to the runtime package

[Emmanuel Vadot]

On Mon, 4 Jan 2021 12:58:58 -0800 (PST)
"Rodney W. Grimes" <freebsd at gndrsh.dnsmgr.net> wrote:

> > On Mon, 4 Jan 2021 12:49:19 -0800 (PST)
> > "Rodney W. Grimes" <freebsd at gndrsh.dnsmgr.net> wrote:
> > 
> > > > The branch main has been updated by manu:
> > > > 
> > > > URL: https://cgit.FreeBSD.org/src/commit/?id=2d486ba15f3367072d631ee588192ef46687fa4b
> > > > 
> > > > commit 2d486ba15f3367072d631ee588192ef46687fa4b
> > > > Author:     Emmanuel Vadot <manu at freebsd.org>
> > > > AuthorDate: 2020-12-21 15:00:02 +0000
> > > > Commit:     Emmanuel Vadot <manu at FreeBSD.org>
> > > > CommitDate: 2021-01-04 15:17:12 +0000
> > > > 
> > > >     pkgbase: Move bectl to the runtime package
> > > >     
> > > >     runtime contain what is needed to boot in single user and repair a
> > > >     system, bectl could be handy to have in this situation.
> > > 
> > > I would think it belongs in the zfs package,
> > > as unless you have zfs you do not need bectrl.
> > 
> >  There is no zfs package.
> 
> I would consider that an oversight.

 I don't. We don't have a ufs package for example.

> >  Having zfs is controlled by WITH/WITHOUT_ZFS and this is not related
> > to pkgbase.
> 
> WITH/WITHOUT are compile time constructs, pkgbase is an install time
> set of tools, why can there not be a zfs pkg?  

 pkgbase is just a reflection of what is built. There can be a zfs
package nothing prevent us for having one. But as said in the commit
runtime is the package that should contain everything needed for
booting to single user and repair a system so it contain zfs related
tools (and ufs ones).
 The idea behind runtime is that if you start upgrading and things
break just after it you have all the tools to repair an install.

> > > 
> > > >     
> > > >     Differential Revision:  https://reviews.freebsd.org/D27708
> > > > ---
> > > >  lib/libbe/Makefile  | 1 +
> > > >  sbin/bectl/Makefile | 1 +
> > > >  2 files changed, 2 insertions(+)
> > > > 
> > > > diff --git a/lib/libbe/Makefile b/lib/libbe/Makefile
> > > > index 291e2438ee2a..d1fab41578bf 100644
> > > > --- a/lib/libbe/Makefile
> > > > +++ b/lib/libbe/Makefile
> > > > @@ -4,6 +4,7 @@ SHLIBDIR?=	/lib
> > > >  
> > > >  .include <src.opts.mk>
> > > >  
> > > > +PACKAGE=	runtime
> > > >  LIB=		be
> > > >  SHLIB_MAJOR=	1
> > > >  SHLIB_MINOR=	0
> > > > diff --git a/sbin/bectl/Makefile b/sbin/bectl/Makefile
> > > > index 6fa84f48661d..46d43306b9ca 100644
> > > > --- a/sbin/bectl/Makefile
> > > > +++ b/sbin/bectl/Makefile
> > > > @@ -2,6 +2,7 @@
> > > >  
> > > >  .include <src.opts.mk>
> > > >  
> > > > +PACKAGE=runtime
> > > >  PROG=	bectl
> > > >  MAN=	bectl.8
> > > >  
> > > > 
> > > 
> > > -- 
> > > Rod Grimes                                                 rgrimes at freebsd.org
> > 
> > 
> > -- 
> > Emmanuel Vadot <manu at bidouilliste.com>
> > 
> 
> -- 
> Rod Grimes                                                 rgrimes at freebsd.org


-- 
Emmanuel Vadot <manu at bidouilliste.com>