git: cd992885bcdf - main - Disable PIE for MIPS ubldr

Marcin Wojtas mw at FreeBSD.org
Wed Feb 24 23:26:42 UTC 2021


The branch main has been updated by mw:

URL: https://cgit.FreeBSD.org/src/commit/?id=cd992885bcdfb3c2c6b761f5c3bf1c86949acdc3

commit cd992885bcdfb3c2c6b761f5c3bf1c86949acdc3
Author:     Marcin Wojtas <mw at FreeBSD.org>
AuthorDate: 2021-02-12 15:41:49 +0000
Commit:     Marcin Wojtas <mw at FreeBSD.org>
CommitDate: 2021-02-24 23:26:11 +0000

    Disable PIE for MIPS ubldr
    
    When performing buildworld for MIPS with PIE enabled, the build fails
    with "position-independent code requires '-mabicalls'" message.
    -mno-abicalls and -fno-pic flags are explicitly set in MIPS ubldr
    makefile, so to work around this problem, set MK_PIE=no for MIPS
    ubldr.
    
    Submitted by: Dawid Gorecki <dgr at semihalf.com>
    Reviewed by: emaste
    Obtained from: Semihalf
    Sponsored by: Stormshield
    Differential Revision: https://reviews.freebsd.org/D28370
---
 stand/mips/uboot/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/stand/mips/uboot/Makefile b/stand/mips/uboot/Makefile
index 1162b7fed3b0..984582027de5 100644
--- a/stand/mips/uboot/Makefile
+++ b/stand/mips/uboot/Makefile
@@ -44,6 +44,10 @@ LDADD=		${LDR_INTERP} ${LIBUBOOT} ${LIBFDT} ${LIBUBOOT_FDT} ${LIBSA}
 
 OBJS+=  ${SRCS:N*.h:R:S/$/.o/g}
 
+# ubldr on MIPS is built with '-mno-abicalls' flag,
+# which is incompatible with PIE
+MK_PIE=		no
+
 ldscript.abs:
 	echo "UBLDR_LOADADDR = ${UBLDR_LOADADDR};" >${.TARGET}
 


More information about the dev-commits-src-all mailing list