git: 9b2f020c14af - main - Handle partial data re-sending on ktls/sendfile on FreeBSD

[John Baldwin]

The branch main has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=9b2f020c14af71a2606012143432dd717c7cf90e

commit 9b2f020c14af71a2606012143432dd717c7cf90e
Author:     Oleksandr Tymoshenko <gonzo at FreeBSD.org>
AuthorDate: 2021-02-17 22:49:30 +0000
Commit:     John Baldwin <jhb at FreeBSD.org>
CommitDate: 2021-02-17 22:51:55 +0000

    Handle partial data re-sending on ktls/sendfile on FreeBSD
    
    Add a handler for EBUSY sendfile error in addition to
    EAGAIN. With EBUSY returned the data still can be partially
    sent and user code has to be notified about it, otherwise it
    may try to send data multiple times.
    
    PR:             251969
    Reviewed by:    jkim
    Obtained from:  OpenSSL (dfcfd17f2818cf520ce6381aed9ec3d2fc12170d)
    MFC after:      1 week
    Sponsored by:   Netflix (merging to FreeBSD)
    Differential Revision:  https://reviews.freebsd.org/D28714
---
 crypto/openssl/doc/man3/SSL_write.pod  | 3 ++-
 crypto/openssl/include/internal/ktls.h | 9 +++------
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/crypto/openssl/doc/man3/SSL_write.pod b/crypto/openssl/doc/man3/SSL_write.pod
index 20c7953deb06..9b271d8e65a2 100644
--- a/crypto/openssl/doc/man3/SSL_write.pod
+++ b/crypto/openssl/doc/man3/SSL_write.pod
@@ -120,7 +120,8 @@ For SSL_sendfile(), the following return values can occur:
 =item Z<>>= 0
 
 The write operation was successful, the return value is the number
-of bytes of the file written to the TLS/SSL connection.
+of bytes of the file written to the TLS/SSL connection. The return
+value can be less than B<size> for a partial write.
 
 =item E<lt> 0
 
diff --git a/crypto/openssl/include/internal/ktls.h b/crypto/openssl/include/internal/ktls.h
index 9032c0ed6174..622d7be76d1e 100644
--- a/crypto/openssl/include/internal/ktls.h
+++ b/crypto/openssl/include/internal/ktls.h
@@ -192,15 +192,12 @@ static ossl_inline int ktls_read_record(int fd, void *data, size_t length)
 static ossl_inline ossl_ssize_t ktls_sendfile(int s, int fd, off_t off,
                                               size_t size, int flags)
 {
-    off_t sbytes;
+    off_t sbytes = 0;
     int ret;
 
     ret = sendfile(fd, s, off, size, NULL, &sbytes, flags);
-    if (ret == -1) {
-	    if (errno == EAGAIN && sbytes != 0)
-		    return sbytes;
-	    return -1;
-    }
+    if (ret == -1 && sbytes == 0)
+        return -1;
     return sbytes;
 }