git: ee10666327b6 - main - Links for bmake and bmake.1

[Peter Jeremy]

On 2021-Feb-15 01:22:58 +0000, "Simon J. Gerraty" <sjg at FreeBSD.org> wrote:
>The branch main has been updated by sjg:
>
>URL: https://cgit.FreeBSD.org/src/commit/?id=ee10666327b622c2f20a4ac17e7a5673b04e7c9a
>
>commit ee10666327b622c2f20a4ac17e7a5673b04e7c9a
>Author:     Simon J. Gerraty <sjg at FreeBSD.org>
>AuthorDate: 2021-02-15 01:20:10 +0000
>Commit:     Simon J. Gerraty <sjg at FreeBSD.org>
>CommitDate: 2021-02-15 01:22:21 +0000
>
>    Links for bmake and bmake.1
>    
>    Some folk forget that make is bmake, and want the links...

This breaks installworld with DESTDIR set:
...
install  -o root  -g wheel -m 444  /usr/src/usr.bin/bmake/tests/variables/t0/expected.stdout.1 /mnt/usr/tests/usr.bin/bmake/variables/t0/expected.stdout.1
install  -o root  -g wheel -m 444  Kyuafile /mnt/usr/tests/usr.bin/bmake/variables/t0/Kyuafile
install -l h -o root -g wheel -m 555  /mntmake /mntbmake
install: link /mntmake -> /mntbmake: No such file or directory
*** Error code 71

I suspect you want something like:
LINKS= ${BINDIR}/make ${BINDIR}/bmake

Also, it seems odd that you only want the link if tests are enabled -
this would seem likely to create more confusion, rather than less.

-- 
Peter Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/dev-commits-src-all/attachments/20210216/680c6a00/attachment.sig>