git: 3bc17248d317 - main - devfs: fix use count leak when using TIOCSCTTY

Mateusz Guzik mjg at FreeBSD.org
Tue Feb 9 01:54:56 UTC 2021


The branch main has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=3bc17248d31794519ba95b2c6b9ff8a0d31dba81

commit 3bc17248d31794519ba95b2c6b9ff8a0d31dba81
Author:     Mateusz Guzik <mjg at FreeBSD.org>
AuthorDate: 2021-02-08 22:10:57 +0000
Commit:     Mateusz Guzik <mjg at FreeBSD.org>
CommitDate: 2021-02-09 01:54:21 +0000

    devfs: fix use count leak when using TIOCSCTTY
    
    by matching devfs_ctty_ref
    
    Fixes: 3b44443626603f65 ("devfs: rework si_usecount to track opens")
---
 sys/fs/devfs/devfs_vnops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/fs/devfs/devfs_vnops.c b/sys/fs/devfs/devfs_vnops.c
index 983bfc803999..043cee74fde2 100644
--- a/sys/fs/devfs/devfs_vnops.c
+++ b/sys/fs/devfs/devfs_vnops.c
@@ -974,7 +974,7 @@ devfs_ioctl(struct vop_ioctl_args *ap)
 
 		/* Get rid of reference to old control tty */
 		if (vpold)
-			vrele(vpold);
+			devfs_ctty_unref(vpold);
 	}
 	return (error);
 }


More information about the dev-commits-src-all mailing list