git: 81e074d57dfc - main - libkern: use compiler builtins for strcpy, strcmp and strlen

Jessica Clarke jrtc27 at freebsd.org
Mon Feb 8 23:29:28 UTC 2021


On 8 Feb 2021, at 22:08, Alexander Richardson <arichardson at freebsd.org> wrote:
> 
> On Mon, 8 Feb 2021, 19:37 Jessica Clarke, <jrtc27 at freebsd.org> wrote:
>> On 8 Feb 2021, at 19:15, Mateusz Guzik <mjg at FreeBSD.org> wrote:
>> > 
>> > The branch main has been updated by mjg:
>> > 
>> > URL: https://cgit.FreeBSD.org/src/commit/?id=81e074d57dfcd86f152e2848dc44b77087ee7a2d
>> > 
>> > commit 81e074d57dfcd86f152e2848dc44b77087ee7a2d
>> > Author:     Mateusz Guzik <mjg at FreeBSD.org>
>> > AuthorDate: 2021-02-07 19:50:25 +0000
>> > Commit:     Mateusz Guzik <mjg at FreeBSD.org>
>> > CommitDate: 2021-02-08 19:15:21 +0000
>> > 
>> >    libkern: use compiler builtins for strcpy, strcmp and strlen
>> 
>> Why?
> 
> 
> I guess because the kernel uses -ffreestanding, so the libcall inlining optimization requires explicit uses of __builtin_foo

That would make sense, but such info belongs in the commit message, a
comment or both... As it stands the message is not useful as anyone can
see from reading the diff that that's what it does.

Jess



More information about the dev-commits-src-all mailing list