git: 2a39919364b5 - main - readelf: Fix printing NT_FREEBSD_ARCH_TAG

Alex Richardson arichardson at FreeBSD.org
Wed Feb 3 16:04:26 UTC 2021


The branch main has been updated by arichardson:

URL: https://cgit.FreeBSD.org/src/commit/?id=2a39919364b5368e026f656ff41861a3fdd56110

commit 2a39919364b5368e026f656ff41861a3fdd56110
Author:     Alex Richardson <arichardson at FreeBSD.org>
AuthorDate: 2021-02-03 15:24:28 +0000
Commit:     Alex Richardson <arichardson at FreeBSD.org>
CommitDate: 2021-02-03 15:44:39 +0000

    readelf: Fix printing NT_FREEBSD_ARCH_TAG
    
    Looking at lib/csu/arm/crt1_s.S, this should be a string and therefore the
    restriction to 4 characters seems wrong.
    Found whle updating https://reviews.llvm.org/D74393.
    
    Reviewed By:    emaste
    Differential Revision: https://reviews.freebsd.org/D28470
---
 contrib/elftoolchain/readelf/readelf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/contrib/elftoolchain/readelf/readelf.c b/contrib/elftoolchain/readelf/readelf.c
index 88d87f96bb72..0964f3529d1b 100644
--- a/contrib/elftoolchain/readelf/readelf.c
+++ b/contrib/elftoolchain/readelf/readelf.c
@@ -3741,9 +3741,7 @@ dump_notes_data(struct readelf *re, const char *name, uint32_t type,
 			return;
 		/* NT_FREEBSD_NOINIT_TAG carries no data, treat as unknown. */
 		case NT_FREEBSD_ARCH_TAG:
-			if (sz != 4)
-				goto unknown;
-			printf("   Arch tag: %x\n", ubuf[0]);
+			printf("   Arch tag: %s\n", buf);
 			return;
 		case NT_FREEBSD_FEATURE_CTL:
 			if (sz != 4)


More information about the dev-commits-src-all mailing list