git: 5b8f07b12f84 - main - Fix -Wformat errors in pfctl on 32-bit architectures

Dimitry Andric dim at FreeBSD.org
Sun Aug 29 17:40:22 UTC 2021


On 29 Aug 2021, at 18:00, Kristof Provost <kp at freebsd.org> wrote:
> 
> On 29 Aug 2021, at 17:31, Dimitry Andric wrote:
>> The branch main has been updated by dim:
>> 
>> URL: https://cgit.FreeBSD.org/src/commit/?id=5b8f07b12f8477f1679013d6b3abdab8d33c7243
>> 
>> commit 5b8f07b12f8477f1679013d6b3abdab8d33c7243
>> Author:     Dimitry Andric <dim at FreeBSD.org>
>> AuthorDate: 2021-08-29 15:31:28 +0000
>> Commit:     Dimitry Andric <dim at FreeBSD.org>
>> CommitDate: 2021-08-29 15:31:28 +0000
>> 
>>    Fix -Wformat errors in pfctl on 32-bit architectures
>> 
>>    Use PRIu64 to printf(3) uint64_t quantities, otherwise this will result
>>    in "error: format specifies type 'unsigned long' but the argument has
>>    type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]" on 32-bit
>>    architectures.
>> 
>>    Fixes:          80078d9d38fd
>>    MFC after:      1 week
> 
> Thanks!
> 
> I was running test builds for a fix, but it is so much more convenient when other people fix my mistakes for me.

I was trying buildworld on i386 for something totally unrelated, and ran
into these -Wformat errors so I took the liberty of patching them up
quickly. :)

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.freebsd.org/pipermail/dev-commits-src-all/attachments/20210829/f607f072/attachment-0001.sig>


More information about the dev-commits-src-all mailing list