git: 22997b755013 - main - pci_dw: Drop unconditional explicit DEBUG define

Jessica Clarke jrtc27 at FreeBSD.org
Sat Aug 7 20:26:27 UTC 2021


The branch main has been updated by jrtc27:

URL: https://cgit.FreeBSD.org/src/commit/?id=22997b755013bdde60119fdc781769192ab7e1e0

commit 22997b755013bdde60119fdc781769192ab7e1e0
Author:     Jessica Clarke <jrtc27 at FreeBSD.org>
AuthorDate: 2021-08-07 20:25:36 +0000
Commit:     Jessica Clarke <jrtc27 at FreeBSD.org>
CommitDate: 2021-08-07 20:25:36 +0000

    pci_dw: Drop unconditional explicit DEBUG define
    
    This has been present since the first revision of the file. The debugf
    macros have always been unused so it doesn't actually do anything
    useful, and besides, debugging should not be unconditionally turned on
    for a production driver. Moreover, this breaks the riscv LINT kernel
    build as sys/conf/NOTES includes options DEBUG, resulting in a macro
    redefinition error. This does not show up in the arm64 LINT kernel build
    since that has an explicit nooptions DEBUG, which is dubious and should
    be revisited. Rather than copy such a hack to riscv's NOTES, fix this
    specific instance of DEBUG breaking.
    
    Fixes:          896e217a0eae ("fu740_pci_dw: Add SiFive FU740 PCIe controller driver")
    MFC after:      1 week
---
 sys/dev/pci/pci_dw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sys/dev/pci/pci_dw.c b/sys/dev/pci/pci_dw.c
index 9eb7b04dfd28..e31779b2bea1 100644
--- a/sys/dev/pci/pci_dw.c
+++ b/sys/dev/pci/pci_dw.c
@@ -59,7 +59,6 @@ __FBSDID("$FreeBSD$");
 #include "pcib_if.h"
 #include "pci_dw_if.h"
 
-#define	DEBUG
 #ifdef DEBUG
 #define	debugf(fmt, args...) do { printf(fmt,##args); } while (0)
 #else


More information about the dev-commits-src-all mailing list