git: e657f3de6dc2 - main - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave()

[Rick Macklem]

Neel wrote:
>On 2021-04-26 09:47, Kevin Bowling wrote:
>> I'm not sure all the context or conversation here but the convention
>> is to not use bare return values, i.e in style(9) "Values in return
>> statements should be enclosed in parentheses." and that's what was
>> asked to be changed on this mailing list.
Just fyi to everyone, there is this in style(9):
     In general code can be considered “new code” when it makes up about 50%
     or more of the file(s) involved.  This is enough to break precedents in
     the existing code and use the current style guidelines.

As such, if the "return 0;" predates this patch series, Neel is correct
to use "return 1;", since that precedent has already been established.
I'll admit I see the above ignored a lot and personally don't care if
the above generality is followed, but it is in style(9) and I do
think a consistent style is preferred over a jumble within a source file.

rick

The review: https://reviews.freebsd.org/D29988

I believe I was asked to do this in the review.

-Neel
>
> Can you use and link to Phabricator for your src commits?  As much as
> possible it is preferable to get it right in one go, for MFCs,
> bisection, etc and this kind of churn should be preventable with quick
> reviews.  Feel free to tag me as a reviewer.

Sure, will do next time.


> Regards,
> Kevin

-Neel