git: 9db8b85a942d - stable/13 - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave()

Rodney W. Grimes freebsd at gndrsh.dnsmgr.net
Mon Apr 26 19:00:56 UTC 2021


> On Mon, Apr 26, 2021 at 10:49 AM Neel Chauhan <nc at freebsd.org> wrote:
> 
> > On 2021-04-26 09:42, John Baldwin wrote:
> > > I agree.  20 minutes is far too short.  The normal minimum is 3 days.
> > > You already have feedback on the commits to main that you should
> > > probably adjust before merging (specifically Mateusz's quite salient
> > > point).
> > > Requiring two immediate fixups to the original commit in main is also
> > > indicative that the change in question isn't really ready yet.
> >
> > Sorry about this. I'm new(-ish?) to src.
> >
> > The immediate "fixups" are just formatting changes that were requested,
> > not really bugfixes.
> >
> 
> Only extremely urgent security-related or build-breakage-fixes are to be
> MFC'd faster than 3 days.
> At least that's been the rule we've articulated in the past. There's been
> some flexibility for things
> that are important, or when racing a release / snapshot schedule (eg a
> really good reason based
> on external factors)

Furthermore the original commit did infact state MFC: 3 days.  I was
shocked to see the immediate merge, but did flow to the end of the
thread before replying.

> Warner
-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the dev-commits-src-all mailing list