git: 9db8b85a942d - stable/13 - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave()

John Baldwin jhb at FreeBSD.org
Mon Apr 26 16:42:19 UTC 2021


On 4/26/21 9:02 AM, Shawn Webb wrote:
> On Mon, Apr 26, 2021 at 03:45:10PM +0000, Neel Chauhan wrote:
>> The branch stable/13 has been updated by nc (ports committer):
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=9db8b85a942dd5e73c0c17198835097a30dc1f7c
>>
>> commit 9db8b85a942dd5e73c0c17198835097a30dc1f7c
>> Author:     Neel Chauhan <nc at FreeBSD.org>
>> AuthorDate: 2021-04-26 15:25:33 +0000
>> Commit:     Neel Chauhan <nc at FreeBSD.org>
>> CommitDate: 2021-04-26 15:45:05 +0000
>>
>>      linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave()
>>      
>>      (cherry picked from commit e657f3de6dc29147b5373d2cc2cc47e580931e30)
> 
> Hey Neel,
> 
> Don't commits usually spend some soak time in main before being
> cherry-picked to stable branches? I'm curious why the lack of soak
> time here.

I agree.  20 minutes is far too short.  The normal minimum is 3 days.
You already have feedback on the commits to main that you should
probably adjust before merging (specifically Mateusz's quite salient point).
Requiring two immediate fixups to the original commit in main is also
indicative that the change in question isn't really ready yet.

-- 
John Baldwin


More information about the dev-commits-src-all mailing list