git: 52489f2a55e6 - main - ng_ubt: Do not clear stall before receiving of HCI command response.

Vladimir Kondratyev wulf at FreeBSD.org
Thu Apr 15 14:29:30 UTC 2021


The branch main has been updated by wulf:

URL: https://cgit.FreeBSD.org/src/commit/?id=52489f2a55e625ea35bccc3749ca3adad6ce0c54

commit 52489f2a55e625ea35bccc3749ca3adad6ce0c54
Author:     Vladimir Kondratyev <wulf at FreeBSD.org>
AuthorDate: 2021-04-15 14:25:00 +0000
Commit:     Vladimir Kondratyev <wulf at FreeBSD.org>
CommitDate: 2021-04-15 14:25:00 +0000

    ng_ubt: Do not clear stall before receiving of HCI command response.
    
    Unconditional execution of "clear feature" request at SETUP stage was
    workaround for probe failures on ng_ubt.ko re-kldloading which is
    unnecessary now.
    
    Reviewed by:    hselasky
    MFC after:      2 weeks
    Differential revision:  https://reviews.freebsd.org/D29775
---
 sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c b/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
index 30a012702c8f..8b93687c6688 100644
--- a/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
+++ b/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
@@ -825,8 +825,6 @@ ubt_probe_intr_callback(struct usb_xfer *xfer, usb_error_t error)
 
         case USB_ST_SETUP:
 submit_next:
-		/* Try clear stall first */
-		usbd_xfer_set_stall(xfer);
 		usbd_xfer_set_frame_len(xfer, 0, usbd_xfer_max_len(xfer));
 		usbd_transfer_submit(xfer);
 		break;
@@ -835,6 +833,8 @@ submit_next:
 		if (error != USB_ERR_CANCELLED) {
 			printf("ng_ubt: interrupt transfer failed: %s\n",
 				usbd_errstr(error));
+			/* Try clear stall first */
+			usbd_xfer_set_stall(xfer);
 			goto submit_next;
 		}
 		break;


More information about the dev-commits-src-all mailing list