git: 5742f2d89c03 - main - arm64: adjust comments in dbg_monitor_exit()

Mitchell Horne mhorne at FreeBSD.org
Tue Apr 13 17:47:13 UTC 2021


The branch main has been updated by mhorne:

URL: https://cgit.FreeBSD.org/src/commit/?id=5742f2d89c03311e8b2d92422c0e2e4063cb2e1d

commit 5742f2d89c03311e8b2d92422c0e2e4063cb2e1d
Author:     Mitchell Horne <mhorne at FreeBSD.org>
AuthorDate: 2021-04-13 17:34:58 +0000
Commit:     Mitchell Horne <mhorne at FreeBSD.org>
CommitDate: 2021-04-13 17:41:31 +0000

    arm64: adjust comments in dbg_monitor_exit()
    
    These comments were copied from dbg_monitor_enter(), but the intended
    modifications weren't made. Update them to reflect what this code
    actually does.
    
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation
---
 sys/arm64/arm64/debug_monitor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/arm64/arm64/debug_monitor.c b/sys/arm64/arm64/debug_monitor.c
index c3dce1883e68..8ef2ba360786 100644
--- a/sys/arm64/arm64/debug_monitor.c
+++ b/sys/arm64/arm64/debug_monitor.c
@@ -583,11 +583,11 @@ dbg_monitor_exit(struct thread *thread, struct trapframe *frame)
 	if (!(SV_PROC_FLAG(thread->td_proc, SV_ILP32)))
 		frame->tf_spsr |= PSR_D;
 	if ((thread->td_pcb->pcb_dbg_regs.dbg_flags & DBGMON_ENABLED) != 0) {
-		/* Install the kernel version of the registers */
+		/* Install the thread's version of the registers */
 		dbg_register_sync(&thread->td_pcb->pcb_dbg_regs);
 		frame->tf_spsr &= ~PSR_D;
 	} else if ((kernel_monitor.dbg_flags & DBGMON_ENABLED) != 0) {
-		/* Disable the user breakpoints until we return to userspace */
+		/* Disable the kernel breakpoints until we re-enter */
 		for (i = 0; i < dbg_watchpoint_num; i++) {
 			dbg_wb_write_reg(DBG_REG_BASE_WCR, i, 0);
 			dbg_wb_write_reg(DBG_REG_BASE_WVR, i, 0);


More information about the dev-commits-src-all mailing list