git: dfff37765ce4 - main - Rename struct device to struct _device

Alexey Dokuchaev danfe at freebsd.org
Mon Apr 12 17:15:29 UTC 2021


On Mon, Apr 12, 2021 at 07:30:30AM -0700, Cy Schubert wrote:
> Mark Johnston writes:
> >
> >     Rename struct device to struct _device
> >     [...]
> 
> Not that a name matters much but struct _device gives me a sense that
> the struct is ancillary. Whereas freebsd_device or fbsd_device is more
> descriptive and gives the struct the status it deserves.

It should not be needed, AFAIR, as device_t is one of a few properly opaque
typedefs for (opaque) struct pointers.  Bruce had explained this in detail
a couple of times, at least:

https://lists.freebsd.org/pipermail/svn-src-head/2011-October/030894.html
https://lists.freebsd.org/pipermail/svn-src-head/2016-May/085790.html

./danfe


More information about the dev-commits-src-all mailing list