git: 06d8a116bd6b - main - libc: add _get_tp() private function

Jessica Clarke jrtc27 at freebsd.org
Fri Apr 9 20:57:57 UTC 2021


On 9 Apr 2021, at 21:47, Konstantin Belousov <kib at FreeBSD.org> wrote:
> 
> The branch main has been updated by kib:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=06d8a116bd6b6f70b8aedc6a6a2c4085c53f63ac
> 
> commit 06d8a116bd6b6f70b8aedc6a6a2c4085c53f63ac
> Author:     Konstantin Belousov <kib at FreeBSD.org>
> AuthorDate: 2021-04-05 03:30:35 +0000
> Commit:     Konstantin Belousov <kib at FreeBSD.org>
> CommitDate: 2021-04-09 20:46:24 +0000
> 
>    libc: add _get_tp() private function
> 
>    which returns pointer to tcb

This feels like it should be static inline in a header. Also we already have
_tcb_get in pthread_md.h that should be entirely equivalent, and
_libc_get_static_tls_base that’s basically the same again but with an optional
offset. Can we do something to unify all the inline asm into one place per
architecture rather than growing yet more copies of the same thing?

Jess



More information about the dev-commits-src-all mailing list