git: 269b7d8ac1e5 - stable/12 - tftpd: tests: raise targeted cstd to c11

Ryan Libby rlibby at freebsd.org
Wed Dec 30 18:13:41 UTC 2020


On Wed, Dec 30, 2020 at 3:33 AM Konstantin Belousov <kostikbel at gmail.com> wrote:
>
> On Tue, Dec 29, 2020 at 07:10:02PM -0800, Ryan Libby wrote:
> > I checked amd64 and it failed due to pkru.  I don't think we care to fix
> > that either, but we technically could of course.  For amd64 the external
> > toolchain with gcc 6.4 is broken at the moment but will be fixed after a
> > few more MFCs.
>
> Could you be more specific, please?
>
> What is broken with PKRU, the gcc 6.4 build?  For kernel, or libc?
> Does it work with not-so-ancient gcc?

Sorry, I wasn't clear.

gcc 6.4 from the external toolchain is fine with pkru.  Separately,
there are just a few remaining MFCs to make gcc 6.4 work out of the
box with no WERROR suppression.

gcc 4.2.1 for amd64 is broken, most immediately because of pkru in
libc (because of new instructions and because of a use of the ifunc
attribute).  This is what I meant to say was technically fixable, but
that we didn't care.  (For those reading along who haven't checked,
pkru(3) is x86-only, at least so far.)

Ryan


More information about the dev-commits-src-all mailing list