git: 7db3d97e0ffd - main - iscsid(8): free data allocated by getaddrinfo(3)

Edward Tomasz Napierala trasz at FreeBSD.org
Tue Dec 29 14:52:31 UTC 2020


The branch main has been updated by trasz:

URL: https://cgit.FreeBSD.org/src/commit/?id=7db3d97e0ffd59985b68b30faa012d40da99faa4

commit 7db3d97e0ffd59985b68b30faa012d40da99faa4
Author:     Edward Tomasz Napierala <trasz at FreeBSD.org>
AuthorDate: 2020-12-29 14:47:35 +0000
Commit:     Edward Tomasz Napierala <trasz at FreeBSD.org>
CommitDate: 2020-12-29 14:52:23 +0000

    iscsid(8): free data allocated by getaddrinfo(3)
    
    Reviewed By:    mav
    Sponsored by:   NetApp, Inc.
    Sponsored by:   Klara, Inc.
    Differential Revision: https://reviews.freebsd.org/D27329
---
 usr.sbin/iscsid/iscsid.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/usr.sbin/iscsid/iscsid.c b/usr.sbin/iscsid/iscsid.c
index 7c8e556510ab..a9c68825fb0a 100644
--- a/usr.sbin/iscsid/iscsid.c
+++ b/usr.sbin/iscsid/iscsid.c
@@ -253,6 +253,10 @@ connection_new(int iscsi_fd, const struct iscsi_daemon_request *request)
 			    "using ICL kernel proxy: ISCSIDCONNECT", to_addr);
 		}
 
+		if (from_ai != NULL)
+			freeaddrinfo(from_ai);
+		freeaddrinfo(to_ai);
+
 		return (conn);
 	}
 #endif /* ICL_KERNEL_PROXY */
@@ -330,6 +334,10 @@ connection_new(int iscsi_fd, const struct iscsi_daemon_request *request)
 		log_err(1, "failed to connect to %s", to_addr);
 	}
 
+	if (from_ai != NULL)
+		freeaddrinfo(from_ai);
+	freeaddrinfo(to_ai);
+
 	return (conn);
 }
 


More information about the dev-commits-src-all mailing list