git: 4886d3afe2ed - main - x11-fm/mucommander: unbreak

Alexey Dokuchaev danfe at freebsd.org
Wed Sep 29 18:17:28 UTC 2021


On Wed, Sep 29, 2021 at 11:54:54AM +0000, Koichiro Iwao wrote:
> commit 4886d3afe2edc47f40839f972a1891c0dbd64d65
> 
>     x11-fm/mucommander: unbreak
>     
> ...
> @@ -28,7 +26,7 @@ OPTIONS_DEFINE=	DOCS
>  
>  do-install:
>  	@${MKDIR} ${STAGEDIR}${DATADIR}
> -	${INSTALL_DATA} ${WRKSRC}/mucommander.jar ${STAGEDIR}${DATADIR}
> +	${INSTALL_DATA} ${WRKSRC}/mucommander-0.9.5.jar ${STAGEDIR}${DATADIR}/mucommander.jar

It's generally a bad idea to hardcode version numbers in targets recipes,
as it would have to be changed upon next update.  Why not use something
like ${PORTVERSION:R} instead, in this particular case?

./danfe


More information about the dev-commits-ports-main mailing list