git: 72629b6891c8 - main - ports-mgmt/pkg-devel: Fix packaging from poudriere

[Stefan Esser]

Am 14.09.21 um 14:27 schrieb Alexey Dokuchaev:
> On Tue, Sep 14, 2021 at 11:52:19AM +0000, Emmanuel Vadot wrote:
>> commit 72629b6891c832e57808a0bdb686c2433951c546
>>
>>     ports-mgmt/pkg-devel: Fix packaging from poudriere
>>     
>>     If there is no pkg(8) installed in the jail/host pkg-static will be used
>>     but we don't have pkg-static with SAN so add a link in the WRKSRC.
>>     Also poudriere just extract pkg-static from the pkg archive so cp
>>     instead of symlink
>> ---
>> +.if ${PORT_OPTIONS:MSAN}
>> +post-build:
>> +	@(cd ${WRKSRC}/src && \
>> +		${LN} -fs pkg pkg-static)
>> +.endif
> 
> Why `cd' when `${LN} -fs pkg ${WRKSRC}/src/pkg-static' would suffice?

I wondered about this too, but also about post-install ...

Since source and destination are in the same directory (and thus in the
same file system) a hard link seems to be the best solution, in both cases.

I'd have used "${LN} -f ${WRKSRC}/src/pkg ${WRKSRC}/src/pkg-static" in
post-build and the same concept with appropriate paths in post-install
(in post-install instead of the ${CP}).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/dev-commits-ports-main/attachments/20210914/8b163c58/attachment.sig>