git: 778fa2dc6685 - main - security/nss: Add TODO about ca_root_nss PORTREVISION

Po-Chuan Hsieh sunpoet at freebsd.org
Fri Sep 3 14:54:48 UTC 2021


On Fri, Sep 3, 2021 at 10:43 PM Matthias Andree <mandree at freebsd.org> wrote:

> The branch main has been updated by mandree:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=778fa2dc6685d70615ff113f0fe8c9183e4a84bf
>
> commit 778fa2dc6685d70615ff113f0fe8c9183e4a84bf
> Author:     Matthias Andree <mandree at FreeBSD.org>
> AuthorDate: 2021-09-03 14:41:40 +0000
> Commit:     Matthias Andree <mandree at FreeBSD.org>
> CommitDate: 2021-09-03 14:43:34 +0000
>
>     security/nss: Add TODO about ca_root_nss PORTREVISION
>
>     Since ca_root_nss inherit's nss's PORTVERSION, add a comment
>     to remind maintainers to reset ca_root_nss's PORTREVISION next time
>     that nss's PORTVERSION gets bumped.
>

This is incorrect. security/ca_root_nss uses VERSION_NSS from its own
Makefile (around line 30).
e.g.
https://cgit.freebsd.org/ports/commit/security/ca_root_nss/Makefile?id=7ef74aa064355c0c3c5f24b2a3579eb80dabb965


>     Approved by:    portmgr@ (blanket, comment-only change)
> ---
>  security/nss/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/nss/Makefile b/security/nss/Makefile
> index e4e747fb893c..cb9eb47763b9 100644
> --- a/security/nss/Makefile
> +++ b/security/nss/Makefile
> @@ -1,7 +1,7 @@
>  # Created by: Maxim Sobolev <sobomax at FreeBSD.org>
>
>  PORTNAME=      nss
> -PORTVERSION=   3.69
> +PORTVERSION=   3.69    # when bumping this, please reset PORTREVISION in
> ../ca_root_nss/Makefile
>  CATEGORIES=    security
>  MASTER_SITES=
> MOZILLA/security/${PORTNAME}/releases/${DISTNAME:tu:C/[-.]/_/g}_RTM/src
>
>


More information about the dev-commits-ports-main mailing list