git: f75b9b72e5cb - main - games/fheroes2: look for libpng without suffix, switch to PORTDOCS

Alexey Dokuchaev danfe at freebsd.org
Fri Jun 4 18:55:07 UTC 2021


On Fri, Jun 04, 2021 at 08:49:34PM +0200, Tobias Kortkamp wrote:
> On Fri, Jun 04, 2021 at 12:51:06PM +0000, Piotr Kubaj wrote:
> > The branch main has been updated by pkubaj:
> > 
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=f75b9b72e5cb7ac631cf10f936d185ecd434ad72
> > 
> > commit f75b9b72e5cb7ac631cf10f936d185ecd434ad72
> > Author:     Piotr Kubaj <pkubaj at FreeBSD.org>
> > AuthorDate: 2021-06-04 12:50:57 +0000
> > Commit:     Piotr Kubaj <pkubaj at FreeBSD.org>
> > CommitDate: 2021-06-04 12:50:57 +0000
> > 
> >     games/fheroes2: look for libpng without suffix, switch to PORTDOCS
> 
> I think this is missing
> 
> Reported by:	danfe

It's okay, I'm not hunting for extra attribution, just for better code.

> > -PLIST_FILES=	bin/${PORTNAME} \
> > -		${DOCSDIR}/README.txt \
> > +PLIST_FILES=	bin/${PORTNAME}
> > +PORTDOCS=	${DOCSDIR}/README.txt \
> >  		${DOCSDIR}/changelog.txt
> 
> This won't work.  Files in PORTDOCS are relative to ${DOSCDIR} so
> you need to drop ${DOCSDIR}/.  Also PORTDOCS won't do anything
> without adding a DOCS option.

Yes, I've also noticed that while on the bus (via phone) so could not
reply.  Thanks for following up Tobias.

./danfe


More information about the dev-commits-ports-main mailing list