git: 043e196d694c - 2021Q2 - Add the prepare-commit-msg hook to the repository.

Mathieu Arnold mat at freebsd.org
Tue Apr 20 13:54:54 UTC 2021


On Tue, Apr 20, 2021 at 03:20:39PM +0200, Jan Beich wrote:
> Mathieu Arnold <mat at FreeBSD.org> writes:
> 
> > +# MFH:		<Ports tree branch name.  Request approval for merge.>
> 
> Why bother after https://svnweb.freebsd.org/changeset/ports/556626 ?

The MFH field always was there to note intent, not to get approval.

> > +# Relnotes:	<Set to 'yes' for mention in release notes.>
> 
> "yes" doesn't apply to ports/. Also, some ports/ committers already use
> "Relnotes:" to link to upstream changelog.
> 
> > +# Pull Request:	<https://github.com/freebsd/<repo>/pull/###>
> 
> Looks too GitHub-specific and doesn't allow auto-close by commit.

The script comes from the src tree:
https://cgit.freebsd.org/src/tree/tools/tools/git/hooks/prepare-commit-msg

I only removed the `MFC after` that we do not use in the ports tree.
I don't see why Relnotes or Pull Request cannot be used here too.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/dev-commits-ports-branches/attachments/20210420/50bc21af/attachment.sig>


More information about the dev-commits-ports-branches mailing list