git: 9324aed8ec1e - main - emulators/elliott: fix unused but set variable

Dimitry Andric dim at FreeBSD.org
Sat Oct 2 11:30:40 UTC 2021


The branch main has been updated by dim (src committer):

URL: https://cgit.FreeBSD.org/ports/commit/?id=9324aed8ec1e8eded0cf24824d5fc8732a93155b

commit 9324aed8ec1e8eded0cf24824d5fc8732a93155b
Author:     Dimitry Andric <dim at FreeBSD.org>
AuthorDate: 2021-09-13 07:56:40 +0000
Commit:     Dimitry Andric <dim at FreeBSD.org>
CommitDate: 2021-10-02 11:24:44 +0000

    emulators/elliott: fix unused but set variable
    
    During an exp-run for llvm 13 (see bug 258209), it turned out that
    emulators/elliott fails to build with clang 13:
    
    emulator.c:536:20: error: variable 'y' set but not used [-Werror,-Wunused-but-set-variable]
            int x, x1, y;
                       ^
    1 error generated.
    
    This is because x, x1 and y are used in ncurses getyx() macros, but in
    this case the program is not interested in the y result. Mark it as
    __unused to get rid of the warning.
    
    PR:             258471
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2021Q4
---
 emulators/elliott-803/files/patch-emulator_emulator.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/emulators/elliott-803/files/patch-emulator_emulator.c b/emulators/elliott-803/files/patch-emulator_emulator.c
new file mode 100644
index 000000000000..c8cd49eb7858
--- /dev/null
+++ b/emulators/elliott-803/files/patch-emulator_emulator.c
@@ -0,0 +1,11 @@
+--- emulator/emulator.c.orig	2020-11-27 12:36:20 UTC
++++ emulator/emulator.c
+@@ -533,7 +533,7 @@ bool handle_key(commands_t *cmd,
+         wch[0] = c;
+         wch[1] = L'\0';
+ 
+-        int x, x1, y;
++        int x, x1, y __unused;
+         getyx(pads->status, y, x);
+ 
+         waddwstr(pads->status, wch);


More information about the dev-commits-ports-all mailing list