git: fc75da3a3b2a - main - graphics/libjxl: fix build on powerpc64*

[Piotr Kubaj]

https://github.com/libjxl/libjxl/issues/677

On 21-10-01 09:24:31, Jan Beich wrote:
> Piotr Kubaj <pkubaj at anongoth.pl> writes:
> 
> > On 21-09-30 21:50:21, Jan Beich wrote:
> >> Piotr Kubaj <pkubaj at FreeBSD.org> writes:
> >> 
> >> >     The include in cpu.cc is not actually necessary, so I did not include anything for FreeBSD.
> >> [...]
> >> > +--- tools/cpu/cpu.cc.orig	2021-09-30 15:38:45 UTC
> >> > ++++ tools/cpu/cpu.cc
> >> > +@@ -19,7 +19,9 @@
> >> > + #endif
> >> > + 
> >> > + #if JXL_ARCH_PPC
> >> > +-#include <sys/platform/ppc.h>  // __ppc_get_timebase_freq
> >> > ++#if linux
> >> > ++#include <sys/platform/ppc.h>  // NOLINT __ppc_get_timebase_freq
> >> > ++#endif
> >> > + #endif
> >> 
> >> Can you file a bug via https://github.com/libjxl/libjxl/issues/new ?
> >> That include is probably unused even on Linux after 5175d11717f3
> >> removed __ppc_get_timebase_freq.
> >> 
> >> Note, if you can't sign Google CLA don't submit a fix. Otherwise, upstream
> >> will refuse to read the rationale (PR description), let alone the patch e.g.,
> >> https://github.com/libjxl/libjxl/pull/193
> >
> > No, I don't have a Google account.
> 
> It's not necessary for filing a bug. Doing so on your behalf is
> complicated by not having powerpc64 hardware to verify fixes proposed
> upstream and not having an error log/excerpt for upstream to better
> understand what needs to be changed.
> 
> Outside of CLA upstream is very helpful. FreeBSD is officially supported
> (see JXL_OS_FREEBSD) and fixed timely e.g.,
> https://gitlab.com/wg1/jpeg-xl/-/issues/65
> https://gitlab.com/wg1/jpeg-xl/-/issues/66

-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/attachments/20211001/9764526b/attachment.sig>