git: f45d21ec05cc - main - www/varnish-libvmod-maxminddb: Update to version 1.0.2

[Joseph Mingrone]

On Fri, 2021-05-28 at 18:57, Alexey Dokuchaev <danfe at freebsd.org> wrote:

> On Fri, May 28, 2021 at 06:35:23PM +0000, Allan Jude wrote:
>> ...
>>     www/varnish-libvmod-maxminddb: Update to version 1.0.2

>> @@ -1,5 +1,5 @@
>>  PORTNAME=	libvmod-maxminddb
>> -DISTVERSION=	1.0.1
>> +DISTVERSION=	v1.0.2

> Can you actually ask for review from someone who has a clue next time?

> This is by far not the first time I see bogus commit from src guy while
> it has seemingly proper "approved by" attribution in place.  I honestly
> don't understand how does it end up like this.

> ./danfe

Yes, I missed this.  My eyes just saw 1.0.1 to 1.0.2 and missed the 'v'.

I did build test it on 11, 12, and 13, so while this isn't ideal, I
think you are blowing things out of proportion.  Please look through my
commit history and I think you will generally see careful testing and
very little breakage.  You will also see that I always use
DISTVERSIONPREFIX/DISTVERSION as described in the Porter's Handbook.  I
have been extremely busy in the past few months and this was simply a
mistake.

Alexey, your reaction is hurtful.  The next time you make a mistake, I
will make every effort to be more respectful than you.

Joe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 987 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/attachments/20210528/4c20d2a5/attachment.sig>