git: 1c31059e3d12 - main - x11-wm/twm: generate synthetic WM hints when needed

Matthew D. Fuller fullermd at over-yonder.net
Wed May 12 00:34:44 UTC 2021


On Mon, May 10, 2021 at 12:44:45AM +0200 I heard the voice of
Adriaan de Groot, and lo! it spake thus:
> 
> I'm a bit confused by the "XXX Revisit?" comment and then lines
> 349-351, which set wmhints->input=True .. something that that
> "revisit" line has already done unconditionally.

Well, that's part of why it got an XXX and plea as part of the changes
:)

It was meant as a minimal change to just synthesize the WM_HINTS data;
de-NULL-checking was part of that, but changing the logic (using the
word loosely ;) around it was saved for later.  Later work redid a
lot of that (e.g., r569, r626, etc).  The current code has a lot of
that resolved[0].  Of course, that's well beyond "fix immediate
problem with Chrome", and way more C than you wanna see    :)


[0] https://bazaar.launchpad.net/~ctwm/ctwm/trunk/view/682/add_window.c#L314
    https://bazaar.launchpad.net/~ctwm/ctwm/trunk/view/682/win_utils.c#L1039
    and so on.


-- 
Matthew Fuller     (MF4839)   |  fullermd at over-yonder.net
Systems/Network Administrator |  http://www.over-yonder.net/~fullermd/
           On the Internet, nobody can hear you scream.


More information about the dev-commits-ports-all mailing list