git: 1c31059e3d12 - main - x11-wm/twm: generate synthetic WM hints when needed

[Adriaan de Groot]

On Sunday, 9 May 2021 23:08:13 CEST Matthew D. Fuller wrote:
> >     This is based on a patch from Reddit
> 
> For anybody researching, this presumably comes from the vtwm patch
> 
> https://sourceforge.net/p/vtwm/code/ci/f50508e8b71d6d874229ad3273cf821307d61
> 94b/
> 
> which was a cut-down version of the ctwm fix
> 
> https://bazaar.launchpad.net/~ctwm/ctwm/trunk/revision/558
> 
> 
> (eventually things work their way upstream  ;)


Hey, upstream!

Yes, that looks mighty familiar. I did cut it down some more (I agree with 
your r558 about dropping now-unnecessary checks for a NULL wmhints, but 
frankly the less time I spend looking at C code, the better for me).

I'm a bit confused by the "XXX Revisit?" comment and then lines 349-351, which 
set wmhints->input=True .. something that that "revisit" line has already done 
unconditionally. Anyway, let's just hope for a new twm release this century 
that picks this up, so that you can run Chromium (why?) in twm (that trusty 
fallback).

I'll add the upstream reference to the patch.

[ade]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/attachments/20210510/788f6370/attachment.sig>