cvs commit: src/sys/conf files src/sys/fs/tmpfs tmpfs.h tmpfs_subr.c tmpfs_vnops.c src/sys/i386/i386 bios.c src/sys/ia64/ia64 efi.c sal.c src/sys/libkern memcmp.c src/sys/mips/mips support.S src/sys/sys libkern.h

David O'Brien obrien at FreeBSD.org
Tue Sep 23 22:18:49 UTC 2008


On Tue, Sep 23, 2008 at 05:21:04PM +0000, Bjoern A. Zeeb wrote:
> Below you have changed a few places back to actually use bcmp instead
> of memcmp.
> I see lots of or more places in our kernel using memcmp. Are you
> saying that they all need to be memcmp instead of bcmp and had been
> unproper results so far

I am not saying the memcmp's I did not touch have to be memcmp and cannot
be changed to bcmp().

> or is the files down just a random collection
> of memcmp->bcmp changes introduced with the same commit?

They are not random, but the set of memcmp uses in $ARCH/$ARCH that did
not depend on the memcmp behavior, and are pure BSD files and thus bcmp()
usage should not upset anyone.  I did not touch drivers that may be
trying to share code or otherwise have minimal changes.

-- 
-- David  (obrien at FreeBSD.org)


More information about the cvs-src mailing list