cvs commit: src/share/man/man3 Makefile queue.3 src/sys/sys
scottl at samsco.org
Thu May 22 17:19:23 UTC 2008
Maxim Sobolev wrote:
> Sam Leffler wrote:
>> Maxim Sobolev wrote:
>>> Ed Schouten wrote:
>>>> The OpenBSD version of SLIST_REMOVE_NEXT() needs a reference to
>>>> the list
>>>> head, even though it is unused.
>>> I don't think it's necessary. sys/queue.h API is not supposed to be
>>> portable across different operating systems. The need to pass list
>>> head around may impede macro usefulness.
>> Gratuitous differences impede porting. If it's not a big deal then
>> maintain compatibility. We already have stupid differences in various
>> areas that must be papered over when code is brokered between systems.
> This is local use convenience vs. easy of porting tradeoff. On one hand
> API is used heavily in the kernel on the other I don't think we have lot
> of kernel code being ported from OpenBSD nowadays.
That's pretty presumptuous to say, and untrue.
> So that local use
> convinience should win a big.
It'll be more convenient to follow what Ed is comfortable with and what
he's already done than to nit pick such a minor detail =-)
More information about the cvs-src