cvs commit: src/sys/i386/cpufreq est.c
rpaulo at FreeBSD.org
Fri May 2 10:17:01 UTC 2008
John Baldwin wrote:
> On Thursday 01 May 2008 05:20:06 pm Rui Paulo wrote:
>> John Baldwin wrote:
>>> On Thursday 28 February 2008 02:10:42 pm Rui Paulo wrote:
>>>> rpaulo 2008-02-28 19:10:42 UTC
>>>> FreeBSD src repository
>>>> Modified files:
>>>> sys/i386/cpufreq est.c
>>>> Validate the id16 values gathered from ACPI (previously a TODO item).
>>>> Style changes by me and njl.
>>> What is the purpose of the 'saved_id16' variable? It is never used. I
>>> what might be better is to just read it once at the start of the loop and
>>> then restore it at the end of the loop, though phk@ has overwritten this
>>> the "chew up all battery on laptops at all cost" patch. :-P
>> What do you mean by 'It is never used.' ?
>> % cat -n est.c | grep saved_id16
>> 1082 uint16_t saved_id16;
>> 1111 est_get_id16(&saved_id16);
> Right, it is initialized, but it's value isn't actually _used_ anywhere.
> There isn't a est_set_id16(&saved_id16), etc.
Yes, you're right. Sorry, it was late yesterday :-)
The variable is not necessary and has been removed.
More information about the cvs-src