cvs commit: src/sys/amd64/include param.h src/sys/arm/include param.h src/sys/i386/include param.h src/sys/ia64/include param.h src/sys/powerpc/include param.h src/sys/sparc64/include param.h src/sys/sun4v/include param.h

Robert Watson rwatson at
Thu Mar 27 00:52:43 PDT 2008

On Thu, 27 Mar 2008, John Birrell wrote:

> jb          2008-03-27 05:03:26 UTC
>  FreeBSD src repository
>  Modified files:
>    sys/amd64/include    param.h
>    sys/arm/include      param.h
>    sys/i386/include     param.h
>    sys/ia64/include     param.h
>    sys/powerpc/include  param.h
>    sys/sparc64/include  param.h
>    sys/sun4v/include    param.h
>  Log:
>  When building a kernel module, define MAXCPU the same as SMP so
>  that modules work with and without SMP.

Hmm.  I think this probably is the right thing, but we'll need to be very 
careful to watch for people defining foo[MAXCPU] in globally visible data 
structures in the kernel in such a way that entries for the non-current CPU 
are referenced by any modules.  A casual glance suggests that, right now, this 
is not generally an issue, but something to watch out for, since we do use 
MAXCPU to size a number of kernel data structures.

Robert N M Watson
Computer Laboratory
University of Cambridge

More information about the cvs-src mailing list