cvs commit: src/sys/kern tty_tty.c

Ed Schouten ed at
Tue Jun 3 12:38:18 UTC 2008

ed          2008-06-03 12:38:18 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             tty_tty.c 
  SVN rev 179519 on 2008-06-03 12:38:00Z by ed
  Remove unneeded Giant locking of /dev/tty.
  The Giant lock is acquired in two places in tty_tty.c. In both places,
  it is unneeded.
  There is no reason to specify D_NEEDGIANT on this device node. The
  device node has only been designed to return ENXIO when opened. It
  doesn't make any sense to lock/unlock Giant, just to return this error.
  D_TTY is also unneeded. The unimplemented functions don't need to be
  patched by devfs.
  We don't need to lock Giant when we want to lookup the proper TTY vnode.
  s_ttyvp is already protected by proctree_lock (see devfs_vnops.c).
  Approved by:    philip (mentor)
  Revision  Changes    Path
  1.62      +0 -3      src/sys/kern/tty_tty.c

More information about the cvs-src mailing list