cvs commit: src/lib/libarchive archive_endian.h archive_read_support_format_zip.c

Joerg Sonnenberger joerg at britannica.bec.de
Fri Jan 4 10:42:43 PST 2008


On Fri, Jan 04, 2008 at 09:50:41AM -0800, Tim Kientzle wrote:
>> +be32dec(const void *pp)
>> +{
>> +       unsigned char const *p = (unsigned char const *)pp;
>
> The "const *" is harmless enough, but dropping the
> leading "const" doesn't seem right at all:  'pp'
> is a pointer to const data, 'p' points to
> modifiable data.

This is just reordered. unsigned char const * == const unsigned char *.

Joerg


More information about the cvs-src mailing list