cvs commit: src/sys/dev/ata ata-all.h

[Nate Lawson]

Poul-Henning Kamp wrote:
> In message <477BFB9D.8070201 at root.org>, Nate Lawson writes:
>> Poul-Henning Kamp wrote:
> 
>> Ok, but this still doesn't address the performance loss fixed by this
>> 3-year-old patch:
> 
> I think your patch is wrong because it moves the responsibility for
> the performance in the wrong direction:  We shouldn't have to care
> about this in every single device driver.
> 
> When I created bus_{read|write}_* that was mostly to reduce the
> risk of repetive strain injuries for device driver writers, but
> it was also an attempt to move the responsibility in the right
> direction.
> 
> rman and bus_space was sort of conceived separately, but it is
> time they realize that they are indeed a couple so everybody don't
> have to pretend how surprised they are to see them together at
> this instant.

I'm happy to see this encapsulated, as long as it gets rid of the
unnecessary overhead of what should be merely a structure member
dereference.

Thanks,
-- 
Nate